-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/N] Implement Arithmetic lint #8905
Conversation
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
There's no need to split PR's up this much. There isn't much of a reason to accept the change as it stands. As part of a PR adding a lint for any use of an arithmetic operator the change is perfectly fine. Feel free to keep adding to this PR rather than closing it. Side note the changes you have here will be broken by #8921 when it gets merged. |
There are PRs sitting idle for months and if the Clippy team couldn't merge 9 diff lines in 5 days, my perception is that a full PR would take much, much, much, much longer. Perhaps another reviewer? r? rust-lang/rust-clippy (Blah, doesn't work) |
r? @llogiq |
Ok. Feel free to make the next PR bigger and directly ask for my review. @bors r+ |
📌 Commit 4fc0ee6 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Thank you @llogiq |
Assuming that #8903 is OK, this PR starts the creation of the
Arithmetic
lint with configurable types.My current struggle to get a rustc review inspired me to create smaller PRs in order to easy review and make merges as fast as possible. So the first step here only moves the
arithmetic.rs
file tonumeric_arithmetic.rs
to make room for the new lint.--
changelog: none