-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deps #8605
Remove deps #8605
Conversation
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
This looks interesting. I'll take over the review to take some load of off @camsteffen. I'll review this over the week :) r? @xFrednet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a solid improvement and excellent work. I have one comment and some nits, but just little things.
The changes also had a major improvement for my compilation performance, it cut 30 seconds down to ~9 seconds. And the code is also more readable, IMO. Okay, enough praise 🙃
Everything looks good to me, thank you for this change. I think everyone is going to enjoy the faster compile time for @bors r+ |
📌 Commit ae5af0c has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This remove both
regex
andcargo_metadata
as dependencies makingclippy_dev
compile ~3x faster (~46s -> ~16s locally).cargo_metadata
was used to extract theversion
field fromCargo.toml
, which is done trivially without that.regex
was used to parsedefine_clippy_lint
inupdate_lints
which is now done usingrustc_lexer
. This isn't any simpler, but it compiles ~15s faster and runs ~3x faster (~2.1s -> ~0.7s locally).The next biggest offenders to compile times are
clap
andwinapi
on windows.clap
could be removed, but re-implementing enough is probably more work than it's worth.winapi
is used byopener
andwalkdir
so it's stuck there.changelog: none