Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup #7558

Merged
merged 13 commits into from
Aug 12, 2021
Merged

Rustup #7558

merged 13 commits into from
Aug 12, 2021

Conversation

flip1995
Copy link
Member

r? @ghost

changelog: none

flip1995 and others added 13 commits July 29, 2021 12:16
Since RFC 3052 soft deprecated the authors field anyway, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information, we should remove it from
crates in this repo.
* Use more accurate span for `async move` suggestion
* Use more accurate span for deref suggestion
* Use `multipart_suggestion` more often
Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default

This PR makes the `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` lint warn by default.

To avoid showing a large number of un-actionable warnings to users, we only enable the lint for macros defined in the same crate. This ensures that users will be able to fix the warning by simply removing a semicolon.

In the future, I'd like to enable this lint unconditionally, and eventually make it into a hard error in a future edition. This PR is a step towards that goal.
Use `multipart_suggestions` more

Built on top of #86532
rfc3052 followup: Remove authors field from Cargo manifests

Since RFC 3052 soft deprecated the authors field, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information for contributors, we may as well
remove it from crates in this repo.
rustc: Replace `HirId`s with `LocalDefId`s in `AccessLevels` tables

and passes using those tables - primarily privacy checking, stability checking and dead code checking.

All these passes work with definitions rather than with arbitrary HIR nodes.
r? `@cjgillot`
cc `@lambinoo` (#87487)
@flip1995
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Aug 12, 2021

📌 Commit c3995b5 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Aug 12, 2021

⌛ Testing commit c3995b5 with merge 7bfc26e...

@bors
Copy link
Contributor

bors commented Aug 12, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 7bfc26e to master...

@bors bors merged commit 7bfc26e into rust-lang:master Aug 12, 2021
@bors bors mentioned this pull request Aug 12, 2021
@flip1995 flip1995 deleted the rustup branch August 12, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants