lint unportable clike enum discriminants #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// **Example:** #[repr(usize)] enum NonPortable { X = 0x1_0000_0000, Y = 0 } | ||
| declare_lint! { | ||
| pub ENUM_CLIKE_UNPORTABLE_VARIANT, Warn, | ||
| "finds enums where all variants share a prefix/postfix" |
|
addressed comments |
| use rustc::middle::ty; | ||
| use utils::span_lint; | ||
|
|
||
| /// **What it does:** C-like enums that are `repr(isize/usize)`` and have values that don't fit into an `i32` |
There was a problem hiding this comment.
There is one quote to many after repr(isize/usize) and other wiki entries end with a point 😄
|
addressed comments |
|
rebased |
llogiq
added a commit
that referenced
this pull request
Feb 29, 2016
lint unportable clike enum discriminants
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some context here: rust-lang/rust#24290
in case 16-bit targets become a thing, we should adjust the lint.