Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file names of flat_map_identity test #6669

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

magurotuna
Copy link
Contributor

This patch fixes the file names of the flat_map_identity test.
Previously, their names were started with unnecessary_flat_map even though the lint rule name is flat_map_identity. This inconsistency happened probably because the rule name was changed during the discussion in the PR where this rule was introduced.

ref: #4231

changelog: none

This commit fixes the file names of the `flat_map_identity` test.
Previously, their names were started with `unnecessary_flat_map` even
though the lint rule name is `flat_map_identity`. This inconsistency
happened probably because the rule name was changed during the
discussion in the PR where this rule was introduced.

ref: rust-lang#4231
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 3, 2021
@flip1995
Copy link
Member

flip1995 commented Feb 3, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Feb 3, 2021

📌 Commit 6396b8f has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 3, 2021

⌛ Testing commit 6396b8f with merge 876ffa4...

@bors
Copy link
Contributor

bors commented Feb 3, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 876ffa4 to master...

@bors bors merged commit 876ffa4 into rust-lang:master Feb 3, 2021
@magurotuna magurotuna deleted the fix-test-name branch February 3, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants