Add a note to as_conversions
#6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to clalify its purpose.
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ thanks! |
|
📌 Commit c53192c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen a couple of examples where there are some misunderstandings of
as_conversions(1, 2 and 3). This PR adds the note that explains its purpose and relationship with otherasrelated casts. Open question: should I list every related lints for discoverbility, or just suggest how to find these? I chose the former because there's no way to list only and allasrelated lints (e.g. on All the Clippt Lints, 'cast' includes some noises, butcast_excludes some) even though I cannot guarantee the list will be updated to include future changes.changelog: Add a note to the document of
as_conversions