Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give corrected code #5664

Merged
merged 5 commits into from
Jun 2, 2020
Merged

Give corrected code #5664

merged 5 commits into from
Jun 2, 2020

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented May 31, 2020 •
edited by flip1995
Loading

This PR adds corrected code for doc examples.

I did this in several commits to facilitate review.
Don't hesitate to tell me if I forgot some.
Also, sometimes I felt it was not necessary to give corrected code, but I maybe wrong.

fixes: #4829

changelog: Improve documentation examples across multiple lints.

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 31, 2020
@ThibsG ThibsG force-pushed the GiveCorrectedCode branch from cfa6d3a to 0f0f89d Compare May 31, 2020 11:12
flip1995
flip1995 requested changes May 31, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good overall.

clippy_lints/src/drop_bounds.rs Outdated Show resolved Hide resolved
clippy_lints/src/eta_reduction.rs Outdated Show resolved Hide resolved
clippy_lints/src/eval_order_dependence.rs Outdated Show resolved Hide resolved
clippy_lints/src/fallible_impl_from.rs Outdated Show resolved Hide resolved
clippy_lints/src/functions.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 31, 2020
@ThibsG ThibsG force-pushed the GiveCorrectedCode branch from 79f8f10 to ad0446c Compare June 1, 2020 08:40
@ThibsG ThibsG force-pushed the GiveCorrectedCode branch from ad0446c to 137a3b4 Compare June 1, 2020 08:50
@ThibsG ThibsG requested a review from flip1995 June 1, 2020 17:27
@flip1995
Copy link
Member

flip1995 commented Jun 2, 2020

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jun 2, 2020

📌 Commit 137a3b4 has been approved by flip1995

@flip1995
Copy link
Member

flip1995 commented Jun 2, 2020

@bors p=1

@bors
Copy link
Contributor

bors commented Jun 2, 2020

⌛ Testing commit 137a3b4 with merge 5cb9ef3...

@bors
Copy link
Contributor

bors commented Jun 2, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5cb9ef3 to master...

@bors bors merged commit 5cb9ef3 into rust-lang:master Jun 2, 2020
@ThibsG ThibsG deleted the GiveCorrectedCode branch June 2, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give "corrected" code in examples
4 participants
@ThibsG @rust-highfive @flip1995 @bors