Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing a typo #4847

Merged
merged 1 commit into from
Nov 28, 2019
Merged

fixing a typo #4847

merged 1 commit into from
Nov 28, 2019

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Nov 25, 2019

changelog: none

flip1995
flip1995 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with rustup

@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Nov 25, 2019
@phansch
Copy link
Member

phansch commented Nov 28, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 28, 2019

📌 Commit 47ef539 has been approved by phansch

phansch added a commit to phansch/rust-clippy that referenced this pull request Nov 28, 2019
@phansch
Rollup merge of rust-lang#4847 - rust-lang:offest, r=phansch
a05f3cb 
fixing a typo

changelog: none
@phansch phansch mentioned this pull request Nov 28, 2019
Merged
bors added a commit that referenced this pull request Nov 28, 2019
@bors
Auto merge of #4855 - phansch:rollup-x7yail7, r=phansch
dbdd75a 
Rollup of 3 pull requests

Successful merges:

 - #4832 (Add some positive examples to lint docs)
 - #4842 ([comparison_chain] #4827 Check `core::cmp::Ord` is implemented)
 - #4847 (fixing a typo)

Failed merges:

changelog: none

r? @ghost
@bors bors merged commit 47ef539 into master Nov 28, 2019
@flip1995 flip1995 deleted the offest branch December 3, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llogiq @phansch @bors @flip1995