Use replace_region_in_file for creating the lint list

[flip1995]

r? @phansch

changelog: none

[phansch]

Looks like update_lints expects another change now. Maybe the commas? @flip1995

[flip1995]

Oh yeah. It seems that the formatting of lists and Ctors changed "recently". I was using an old nightly, which didn't include the commas.

Also #4138 renamed a lint. Rebased on master. Now travis should be green 🙏

[phansch]

@bors r+ thanks!

[bors]

📌 Commit 0e480ca has been approved by phansch

[bors]

⌛ Testing commit 0e480ca with merge e5a7722...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing e5a7722 to master...

[tesuji]

Is the backward slash \ necessary?

[flip1995]

No, but this Regex:

rust-clippy/clippy_dev/src/lib.rs

Lines 165 to 167 in be5d17f

	let lints = DEC_CLIPPY_LINT_RE
	.captures_iter(content)
	.map(|m| Lint::new(&m["name"], &m["cat"], &m["desc"], None, filename));

probably adds it, while parsing the description of the lint. This could be handled here

rust-clippy/clippy_dev/src/lib.rs

Line 49 in be5d17f

desc: NL_ESCAPE_RE.replace(&desc.replace("\\\"", "\""), "").to_string(),

just like \" is. 🤔