Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong lifetime of TyCtxt #4200

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Fix wrong lifetime of TyCtxt #4200

merged 2 commits into from
Jun 13, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 12, 2019

Rustup rust-lang/rust#61722

changelog: none

@phansch
Copy link
Member

phansch commented Jun 12, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jun 12, 2019

📌 Commit fd17acb has been approved by phansch

@bors
Copy link
Contributor

bors commented Jun 12, 2019

⌛ Testing commit fd17acb with merge c480344...

bors added a commit that referenced this pull request Jun 12, 2019
Fix wrong lifetime of TyCtxt

Rustup rust-lang/rust#61722

changelog: none
@bors
Copy link
Contributor

bors commented Jun 12, 2019

💔 Test failed - checks-travis

@tesuji
Copy link
Contributor Author

tesuji commented Jun 12, 2019

Spurious failure?

@phansch
Copy link
Member

phansch commented Jun 12, 2019

@bors retry (yup)

bors added a commit that referenced this pull request Jun 12, 2019
Fix wrong lifetime of TyCtxt

Rustup rust-lang/rust#61722

changelog: none
@bors
Copy link
Contributor

bors commented Jun 12, 2019

⌛ Testing commit fd17acb with merge 496841f...

@bors
Copy link
Contributor

bors commented Jun 12, 2019

💔 Test failed - checks-travis

tesuji added 2 commits June 13, 2019 02:49
Sometimes travis gets slow and makes the builds spurious failure because
of no output in 10 minutes. This commit increase Travis timing-out time
at most 30 minutes before terminating the build.
@tesuji tesuji force-pushed the tyctxt-lifetime branch from 6b9dc4d to 3832a8d Compare June 12, 2019 19:50
@tesuji
Copy link
Contributor Author

tesuji commented Jun 12, 2019

@phansch I pushed a new commit to temporarily fix the build timeout.

@matthiaskrgr
Copy link
Member

@bors retry

@matthiaskrgr
Copy link
Member

@bors ping

@bors
Copy link
Contributor

bors commented Jun 12, 2019

😪 I'm awake I'm awake

@matthiaskrgr
Copy link
Member

@bors retry

@matthiaskrgr
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 12, 2019

📌 Commit 3832a8d has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Jun 12, 2019

⌛ Testing commit 3832a8d with merge 0814207...

bors added a commit that referenced this pull request Jun 12, 2019
Fix wrong lifetime of TyCtxt

Rustup rust-lang/rust#61722

changelog: none
@bors
Copy link
Contributor

bors commented Jun 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: matthiaskrgr
Pushing 0814207 to master...

@bors bors merged commit 3832a8d into rust-lang:master Jun 13, 2019
@tesuji tesuji deleted the tyctxt-lifetime branch June 13, 2019 01:16
@tesuji tesuji mentioned this pull request Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants