Use the new rustc interface #3733
Conversation
|
☔ The latest upstream changes (presumably #2857) made this pull request unmergeable. Please resolve the merge conflicts. |
src/driver.rs
Outdated
| struct ClippyCallbacks; | ||
|
|
||
| impl rustc_driver::Callbacks for ClippyCallbacks { | ||
| fn after_parsing(&mut self, compiler: &interface::Compiler<'_>) -> bool { |
There was a problem hiding this comment.
| fn after_parsing(&mut self, compiler: &interface::Compiler<'_>) -> bool { | |
| fn after_parsing(&mut self, compiler: &interface::Compiler) -> bool { |
Won't compile again otherwise
There was a problem hiding this comment.
I'll just fix this myself and merge
Updates clippy to work with new driver stuff from rust-lang/rust#56732 See #3733
|
merge on travis pass |
|
Oh wait bors does that for us lol @bors r+ |
|
📌 Commit 0d4a19c has been approved by |
Use the new rustc interface Shows the changes required to compile with rust-lang/rust#56732
|
💔 Test failed - checks-travis |
| sess.plugin_attributes.borrow_mut().extend(attributes); | ||
|
|
||
| // Continue execution | ||
| true |
There was a problem hiding this comment.
The old code did controller.compilation_done.stop = Compilation::Stop;, isn't this a change in behavior? (Same thing as in Miri, which is the only reason I noticed this.)
There was a problem hiding this comment.
Stopping after compilation is done doesn't really do anything.
There was a problem hiding this comment.
I was mostly worried about Clippy accidentally emitting a binary (which a bug in Miri made it do for some time, and I actually have no idea what made it stop doing that). Not sure if that's related to stopping here.
There was a problem hiding this comment.
The previous (and new) code should emit a binary here.
There was a problem hiding this comment.
Stopping after compilation is done doesn't really do anything.
This might be what's causing cargo clippy not do anything on a second run. We should investigate in the future, but this PR does the right thing in keeping the previous behaviour
|
@bors r+ |
|
📌 Commit 1388f24 has been approved by |
Use the new rustc interface Shows the changes required to compile with rust-lang/rust#56732
|
☀️ Test successful - checks-travis, status-appveyor |
Shows the changes required to compile with rust-lang/rust#56732