Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build of build.rs #3001

Closed
wants to merge 1 commit into from
Closed

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@mati865
Copy link
Contributor

mati865 commented Aug 3, 2018

It shouldn't be required at all, Clippy is 2018 crate already

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Aug 3, 2018

I know.
Maybe there's a bug of how build.rs is handled with editions?

I was able to have

#![feature(rust_2018_preview)]
#![warn(rust_2018_idioms)]

extern crate ansi_term;
extern crate rustc_version;

use ansi_term::Colour::Red;
use rustc_version::{version_meta, version_meta_for, Channel, Version, VersionMeta};
use std::env;

without triggering any warnings.

@mati865
Copy link
Contributor

mati865 commented Aug 3, 2018

@matthiaskrgr does it work if you add #![feature(rust_2018_preview)] and remove all extern crate...?

@matthiaskrgr
Copy link
Member Author

Nope, the build errors return when I do that.

@mati865
Copy link
Contributor

mati865 commented Aug 3, 2018

I think you should reported it to rust/cargo (if it's not reported already) and add comment with link to the issue. It's a workaround and somebody could remove it prematurely.

@phansch
Copy link
Member

phansch commented Aug 5, 2018

Going ahead and closing this because the cargo PR has been merged. We just need to wait for cargo to be updated in rustc and the following nightly.

@phansch phansch closed this Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants