-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove feature=cargo-clippy
argument
#13246
Remove feature=cargo-clippy
argument
#13246
Conversation
Saw it but didn't send the PR yet. Thanks for doing it! 👍 |
No problem at all. =^.^= I'm stuck on some lintcheck stuff and stumbled across this. I decided to fix this and play the ostrich algorithm on the lintcheck thingy for one more day :D |
Same for me. Still going through #11421. ^^' |
@GuillaumeGomez could oli-obk/ui_test#202 potentially help you? I don't know the problem, but I wanted to mention that PR just in case. |
I've been using oli's help quite a few time to fix some issues I had with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, totally forgot about that. I think it's been long enough of a transition phase, so that we can remove it now. But @rust-lang/clippy , if someone thinks we should wait longer, speak now or forever hold your peace.
Let's merge this at the end of the week, if there are no objections.
This should be ready now. @bors r+ |
@bors r- |
@bors r=flip1995 |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Roses are red,
Violets are blue,
Fixme was written,
And now it's due
changelog: Important Change Removed the implicit
cargo-clippy
feature set by Clippy as announced here: https://blog.rust-lang.org/2024/02/28/Clippy-deprecating-feature-cargo-clippy.html#13246
Follow-up of: #12292
r? @flip1995
cc: @GuillaumeGomez