Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos of author lint #12855

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix typos of author lint #12855

merged 1 commit into from
Jun 11, 2024

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 26, 2024

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 26, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 26, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Jun 4, 2024

I don't really see the need for using ast::LitKind. The compiler's error message for trying to use LitKind without importing mentions the full path. I think the same thing happens if you try to import it from rustc_hir as well.

@tesuji tesuji force-pushed the fix-author-lint branch from 073dd51 to 2855a87 Compare June 8, 2024 12:33
@tesuji
Copy link
Contributor Author

tesuji commented Jun 8, 2024

It's true that in compiler error message we see the hints about import path.
However recompiling clippy is never fast enough. But that's only my opinion. So don't mind me.

I removed the ast prefix.

@Jarcho
Copy link
Contributor

Jarcho commented Jun 11, 2024

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Jun 11, 2024

📌 Commit 2855a87 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 11, 2024

⌛ Testing commit 2855a87 with merge aaade2d...

@bors
Copy link
Contributor

bors commented Jun 11, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing aaade2d to master...

@bors bors merged commit aaade2d into rust-lang:master Jun 11, 2024
5 checks passed
@tesuji tesuji deleted the fix-author-lint branch June 12, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants