-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new lint option_map_or_err_ok
#11864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Nov 24, 2023
GuillaumeGomez
force-pushed
the
option_map_or_err_ok
branch
from
November 24, 2023 17:08
2c6b523
to
9359da7
Compare
flip1995
reviewed
Nov 24, 2023
GuillaumeGomez
force-pushed
the
option_map_or_err_ok
branch
from
November 24, 2023 17:14
9359da7
to
ef38969
Compare
Applied suggestions and simplified code. Like I said, I'll send a follow-up for my previous lint as well. |
bors
added a commit
that referenced
this pull request
Nov 25, 2023
…e_none, r=flip1995 Simplify code for `result_map_or_else_none` As mentioned in #11864. r? `@flip1995` changelog: Simplify code for `result_map_or_else_none`
@bors r+ Thanks! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10045.
For the following code:
It suggests to instead write:
r? @flip1995
changelog: Create new lint
option_map_or_err_ok