Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single_match: fix checking of explicitly matched enums #11441

Merged
merged 2 commits into from
Aug 8, 2024
Merged

single_match: fix checking of explicitly matched enums #11441

merged 2 commits into from
Aug 8, 2024

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Sep 1, 2023

fixes #11365

This approach has false-negatives, but fixing them will require a significant amount of additional state tracking. The comment in add_and_pats has the explanation.

changelog: single_match: correct checking if the match explicitly matches all of an enum's variants.

@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 1, 2023
@Jarcho Jarcho force-pushed the issue_11365 branch 2 times, most recently from ce1b80f to f475b85 Compare September 1, 2023 02:32
@bors
Copy link
Contributor

bors commented Sep 25, 2023

☔ The latest upstream changes (presumably #11563) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho
Copy link
Contributor Author

Jarcho commented Feb 14, 2024

r? clippy

@rustbot rustbot assigned dswij and unassigned giraffate Feb 14, 2024
@bors
Copy link
Contributor

bors commented Feb 17, 2024

☔ The latest upstream changes (presumably #12198) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

Hey @dswij , this is a ping from triage. Can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@rustbot ready

@dswij
Copy link
Member

dswij commented Mar 31, 2024

I won't be back until Wednesday. If anyone have the capacity, feel free to review this :)

r? clippy

@rustbot rustbot assigned blyxyas and unassigned dswij Mar 31, 2024
@xFrednet
Copy link
Member

Hey, this is a ping from triage. @blyxyas can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@rustbot ready

@blyxyas
Copy link
Member

blyxyas commented Jun 21, 2024

I've been postponing it for some time, I'll take a deep look at this tomorrow (compromise), if then it doesn't click, I'll do a reroll

@Jarcho Jarcho force-pushed the issue_11365 branch 3 times, most recently from c2e9608 to ca1236d Compare June 25, 2024 19:52
@xFrednet
Copy link
Member

Hey, this is triage: It looks like @blyxyas is currently busy, let's pick a new reviewer.

r? clippy

@rustbot rustbot assigned Manishearth and unassigned blyxyas Jul 23, 2024
@Manishearth
Copy link
Member

r? clippy

(in mumbai for two weeks, not using the computer as much)

@bors
Copy link
Contributor

bors commented Aug 3, 2024

☔ The latest upstream changes (presumably #13115) made this pull request unmergeable. Please resolve the merge conflicts.

xFrednet
xFrednet reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, the rest looks good to me.

clippy_lints/src/matches/single_match.rs Show resolved Hide resolved
@xFrednet
Copy link
Member

xFrednet commented Aug 8, 2024

LGTM, thanks!

Roses are red,
Violets are blue,
This PR has been open,
and should be merged now

@bors
Copy link
Contributor

bors commented Aug 8, 2024

📌 Commit 8bcecff has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 8, 2024

⌛ Testing commit 8bcecff with merge 5ccf543...

@bors
Copy link
Contributor

bors commented Aug 8, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 5ccf543 to master...

@bors bors merged commit 5ccf543 into rust-lang:master Aug 8, 2024
8 checks passed
This was referenced Aug 8, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas left review comments

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single_match incorrectly lints on exhaustive matches inside of Option/Result
8 participants
@Jarcho @rustbot @bors @xFrednet @dswij @blyxyas @Manishearth @giraffate