Mini-fix double_must_use for async functions
#10589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
giraffate
reviewed
Apr 3, 2023
| @@ -43,7 +44,7 @@ pub(super) fn check_item<'tcx>(cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_> | |||
| } | |||
|
|
|||
| pub(super) fn check_impl_item<'tcx>(cx: &LateContext<'tcx>, item: &'tcx hir::ImplItem<'_>) { | |||
| if let hir::ImplItemKind::Fn(ref sig, ref body_id) = item.kind { | |||
| if let hir::ImplItemKind::Fn(ref sig, ref body_id) = item.kind && !sig.header.is_async() /* (#10486) */ { | |||
There was a problem hiding this comment.
Does this affect must_use_unit? If so, it would seem to me that it should be limited to double_must_use only.
There was a problem hiding this comment.
Fixed in the last commit.
There was a problem hiding this comment.
Thanks! I made one comment.
2781fc9 to
d602743
Compare
giraffate
reviewed
Apr 3, 2023
| } | ||
|
|
||
| #[must_use] | ||
| async fn async_must_use_result() -> Result<(), ()> { |
There was a problem hiding this comment.
It looks like that this case is false negative. It would be better to check that the return type in async function already has #[must_use]. I think we can get the type from Future::Output like below:
let infcx = cx.tcx.infer_ctxt().build();
let Some(ret_ty) = infcx.get_impl_future_output_ty(return_ty(cx, item_id));4b27377 to
f4b701e
Compare
f4b701e to
a37eb4d
Compare
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Rust 1.67 onwards, the
#[must_use]attribute also applies to theFuture::Output(rust-lang/rust#100633). So the lintdouble_must_usewas linting all async functions. This PR changes thedouble_must_uselint so it ignoresasyncfunctions.Closes #10486
changelog: [
double_must_use]: Fix false positive in async function