-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FP of single-element-loop #10162
Conversation
r? @flip1995 (rustbot has picked a reviewer for you, use r? to override) |
r? @xFrednet :) I wanted to look at the changes anyways to update the changelog entry, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have one small suggestion, then we can merge this.
Side note: I wonder if it would make more sense, to simply change the applicability and point out, that the break
and continue
statement should be refactored. However, that seems like a lot of effort for little benefit. Some users might even use this pattern to structure their control flow (Even if that might not be ideal). Therefore, I think we should keep this implementation :)
@xFrednet thank you for your review. I've finished fixing code. |
You're welcome, thank you for the swift response. This looks good to me. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
closes #10018
changelog: [
single_element_loop
]: No longer lints, if the loop contains abreak
orcontinue
#10162