unnecessary_move lint, removing move with no effect

[sukyoungjeong-furiosa]

What it does

clippy reports no warnings for unnecessary move keyword, such as:

let closure = move || value_moved(v);

Here move is unnecessary since there's no reference capture.

If a lint for above is acceptable, we may also have some warnings for belows.

std::thread::spawn(move || { value_moved(v) }

or

tokio::spawn(async move || value_moved_async(v).await})

Lint Name

unnecessary_move

Category

style

Advantage

• Brings minimalism.

Drawbacks

No response

Example

move || value_moved(v);

Could be written as:

|| value_moved(v);

[Kinrany]

Duplicate of #11721 #8751

[smoelius]

Duplicate of #8751

@Kinrany Did you mean to post this on a different issue? #11721 maybe?

[Kinrany]

🤦 Yes, thank you!
(Technically that issue is newer and would be a duplicate of this one, but the former actually has some discussion on it)