You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
warning: you don't need to add `&` to all patterns
--> src/interpreter/mod.rs:111:16
|
111 | let name = match node_at!(ast_nodes, 1) {
| ________________^
112 | | &ASTNode::Identifier(ref x) => x,
113 | | _ => runtime_error!("Bad variable name in 'define': {:?}", ast_nodes)
114 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
thread 'rustc' panicked at 'byte index 38 is out of bounds of ` let mut result = empty!();`', src/libcore/str/mod.rs:2027:9
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
1: std::sys_common::backtrace::_print
at src/libstd/sys_common/backtrace.rs:70
2: std::panicking::default_hook::{{closure}}
at src/libstd/sys_common/backtrace.rs:58
at src/libstd/panicking.rs:200
3: std::panicking::default_hook
at src/libstd/panicking.rs:215
4: rustc::util::common::panic_hook
5: std::panicking::rust_panic_with_hook
at src/libstd/panicking.rs:482
6: std::panicking::continue_panic_fmt
at src/libstd/panicking.rs:385
7: rust_begin_unwind
at src/libstd/panicking.rs:312
8: core::panicking::panic_fmt
at src/libcore/panicking.rs:85
9: core::str::slice_error_fail
at src/libcore/str/mod.rs:0
10: core::str::traits::<impl core::slice::SliceIndex<str> for core::ops::range::RangeTo<usize>>::index::{{closure}}
11: <core::iter::Map<I, F> as core::iter::iterator::Iterator>::fold
12: <alloc::vec::Vec<T> as alloc::vec::SpecExtend<T, I>>::from_iter
13: <rustc_errors::emitter::EmitterWriter as rustc_errors::emitter::Emitter>::emit
14: rustc_errors::Handler::emit_db
15: rustc_errors::diagnostic_builder::DiagnosticBuilder::emit
16: clippy_lints::utils::span_lint_and_then
17: <clippy_lints::matches::MatchPass as rustc::lint::LateLintPass<'a, 'tcx>>::check_expr
18: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_expr
19: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_local
20: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_block
21: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_expr
22: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_body
23: rustc::hir::intravisit::walk_fn
24: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_fn
25: rustc::hir::intravisit::walk_item
26: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_item
27: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_mod
28: rustc::hir::intravisit::walk_item
29: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_item
30: <rustc::lint::context::LateContext<'a, 'tcx> as rustc::hir::intravisit::Visitor<'tcx>>::visit_mod
31: rustc::hir::intravisit::walk_crate
32: rustc::lint::context::check_crate
33: rustc::util::common::time
34: <std::thread::local::LocalKey<T>>::with
35: rustc::ty::context::TyCtxt::create_and_enter
36: rustc_driver::driver::compile_input
37: <scoped_tls::ScopedKey<T>>::set
38: rustc_driver::run_compiler
39: <scoped_tls::ScopedKey<T>>::set
query stack during panic:
end of query stack
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.33.0-nightly (bf669d1e3 2019-01-25) running on x86_64-unknown-linux-gnu
note: compiler flags: -C debuginfo=2 -C incremental -C target-cpu=native --crate-type bin
note: some of the compiler flags provided by cargo are hidden
error: Could not compile `mscheme`.
To learn more, run the command again with --verbose.
clippy 0.0.212 (f175352 2019-01-24)
The text was updated successfully, but these errors were encountered:
Fix ICE #3719+#3718 in lint match_ref_pats
Fixes#3719
This conveniently also fixes#3718
The ICE occurs when the match expression was a macro call, where the macro was defined in another file. Since we don't have the ability to reproduce this behavior with our UI tests (AFAIK), I couldn't add a test reproducing this ICE.. However, I added a test which is related to the ICE, to show the new behavior of the lint.
I tested it with the mscheme repo locally and the ICE didn't happen anymore.
r? @matthiaskrgr
clippy 0.0.212 (f175352 2019-01-24)
The text was updated successfully, but these errors were encountered: