-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Lint types with
fn new() -> Self and no Default impl
- Loading branch information
Showing
8 changed files
with
132 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| use rustc::lint::*; | ||
| use rustc_front::hir; | ||
| use rustc_front::intravisit::FnKind; | ||
| use syntax::ast; | ||
| use syntax::codemap::Span; | ||
| use utils::{get_trait_def_id, implements_trait, in_external_macro, returns_self, span_lint, DEFAULT_TRAIT_PATH}; | ||
|
|
||
| /// **What it does:** This lints about type with a `fn new() -> Self` method and no `Default` | ||
| /// implementation. | ||
| /// | ||
| /// **Why is this bad?** User might expect to be able to use `Default` is the type can be | ||
| /// constructed without arguments. | ||
| /// | ||
| /// **Known problems:** Hopefully none. | ||
| /// | ||
| /// **Example:** | ||
| /// | ||
| /// ```rust,ignore | ||
| /// struct Foo; | ||
| /// | ||
| /// impl Foo { | ||
| /// fn new() -> Self { | ||
| /// Foo | ||
| /// } | ||
| /// } | ||
| /// ``` | ||
| declare_lint! { | ||
| pub NEW_WITHOUT_DEFAULT, | ||
| Warn, | ||
| "`fn new() -> Self` method without `Default` implementation" | ||
| } | ||
|
|
||
| #[derive(Copy,Clone)] | ||
| pub struct NewWithoutDefault; | ||
|
|
||
| impl LintPass for NewWithoutDefault { | ||
| fn get_lints(&self) -> LintArray { | ||
| lint_array!(NEW_WITHOUT_DEFAULT) | ||
| } | ||
| } | ||
|
|
||
| impl LateLintPass for NewWithoutDefault { | ||
| fn check_fn(&mut self, cx: &LateContext, kind: FnKind, decl: &hir::FnDecl, _: &hir::Block, span: Span, id: ast::NodeId) { | ||
| if in_external_macro(cx, span) { | ||
| return; | ||
| } | ||
|
|
||
| if let FnKind::Method(name, _, _) = kind { | ||
| if decl.inputs.is_empty() && name.as_str() == "new" { | ||
| let ty = cx.tcx.lookup_item_type(cx.tcx.map.local_def_id(cx.tcx.map.get_parent(id))).ty; | ||
|
|
||
| if returns_self(cx, &decl.output, ty) { | ||
| if let Some(default_trait_id) = get_trait_def_id(cx, &DEFAULT_TRAIT_PATH) { | ||
| if !implements_trait(cx, ty, default_trait_id, Vec::new()) { | ||
| span_lint(cx, NEW_WITHOUT_DEFAULT, span, | ||
| &format!("you should consider adding a `Default` implementation for `{}`", ty)); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #![feature(plugin)] | ||
| #![plugin(clippy)] | ||
|
|
||
| #![allow(dead_code)] | ||
| #![deny(new_without_default)] | ||
|
|
||
| struct Foo; | ||
|
|
||
| impl Foo { | ||
| fn new() -> Foo { Foo } //~ERROR: you should consider adding a `Default` implementation for `Foo` | ||
| } | ||
|
|
||
| struct Bar; | ||
|
|
||
| impl Bar { | ||
| fn new() -> Self { Bar } //~ERROR: you should consider adding a `Default` implementation for `Bar` | ||
| } | ||
|
|
||
| struct Ok; | ||
|
|
||
| impl Ok { | ||
| fn new() -> Self { Ok } | ||
| } | ||
|
|
||
| impl Default for Ok { | ||
| fn default() -> Self { Ok } | ||
| } | ||
|
|
||
| struct Params; | ||
|
|
||
| impl Params { | ||
| fn new(_: u32) -> Self { Params } | ||
| } | ||
|
|
||
| fn main() {} |