Never use spaces in generated name (fixes #844) #845
Conversation
|
|
|
@bors-servo r=fitzgen carried over r+ from #841 |
|
📌 Commit e0bd747 has been approved by |
Never use spaces in generated name (fixes #844) None
|
💔 Test failed - status-travis |
|
@bors-servo r=fitzgen |
|
📌 Commit 5d409fe has been approved by |
Never use spaces in generated name (fixes #844) None
|
@bors-servo r=fitzgen |
|
📌 Commit 333f21a has been approved by |
Never use spaces in generated name (fixes #844) None
|
@bors-servo r- |
| @@ -1391,7 +1391,12 @@ impl<'ctx> BindgenContext<'ctx> { | |||
| _ => return None, | |||
| }; | |||
|
|
|||
| let spelling = ty.spelling(); | |||
| let mut spelling = ty.spelling(); | |||
There was a problem hiding this comment.
just:
let spelling = ty.spelling().replace(' ', "_");|
@bors-servo r=emilio |
|
📌 Commit 2d949e2 has been approved by |
Never use spaces in generated name (fixes #844) None
| B<const int> mBConst; | ||
| B<volatile int> mBVolatile; | ||
| B<const bool> mBConstBool; | ||
| B<const char16_t> mBConstChar; |
There was a problem hiding this comment.
It might probably better to have more, at least something like unsigned long long which has whitespace unrelated to cv, as well as things like long double to cover non-interger types, and probably const decltype(nullptr) might be a good one to test as well.
|
☀️ Test successful - status-travis |
No description provided.