-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbindgen: Make logging optional #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neat, can we move the stubs to other files? Seems like a lot of burden to be in |
Do you prefer: cfg_if! {
if #[cfg(feature = "logging")] {
#[macro_use]
extern crate log;
} else {
#[macro_use]
mod log_stubs;
}
} Or: #[cfg(feature = "logging")]
#[macro_use]
extern crate log;
#[cfg(not(feature = "logging"))]
#[macro_use]
mod log_stubs; |
The second looks nicer IMO, you can drop that comment and we'll land this :) |
Note that the log crate isn't completely banished, as other is required by other dependencies.
jdub
force-pushed
the
logless-library-really
branch
from
November 16, 2016 11:22
19c6dd2
to
a949b5c
Compare
Ready to go. |
@bors-servo r+ |
📌 Commit a949b5c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2016
libbindgen: Make logging optional Note that the log crate isn't completely banished, as other is required by other dependencies. Believe it or not, this change was the original aim of #204.
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the log crate isn't completely banished, as other is required by other dependencies.
Believe it or not, this change was the original aim of #204.