Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid superfluous repeated builds on Travis #265

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

jdub
Copy link
Contributor

@jdub jdub commented Nov 15, 2016

Another fix to greatly improve test suite turnaround times.

@fitzgen
Copy link
Member

fitzgen commented Nov 15, 2016

@bors-servo r+

@bors-servo
Copy link

📌 Commit 2895ae3 has been approved by fitzgen

@jdub
Copy link
Contributor Author

jdub commented Nov 15, 2016

Comparing #204 to #265:

  • ~13 minutes to ~8 minutes on stable
  • ~19 minutes to ~11 minutes on nightly (llvm_stable)
  • ~17 minutes to ~12 minutes on nightly

Neither includes #261, which appears to slow things down a little, but the trade-off is worth it.

@bors-servo
Copy link

⌛ Testing commit 2895ae3 with merge 1bae7d0...

bors-servo pushed a commit that referenced this pull request Nov 15, 2016
Avoid superfluous repeated builds on Travis

Another fix to greatly improve test suite turnaround times.
@bors-servo
Copy link

💔 Test failed - status-travis

@emilio
Copy link
Contributor

emilio commented Nov 15, 2016

Let's disable building on nightly until rust-lang/rust#37786 is resolved.

@fitzgen
Copy link
Member

fitzgen commented Nov 15, 2016

Let's disable building on nightly until rust-lang/rust#37786 is resolved.

I added a ride along commit to #264 that does this.

@fitzgen
Copy link
Member

fitzgen commented Nov 15, 2016

@bors-servo retry

@fitzgen
Copy link
Member

fitzgen commented Nov 15, 2016

@bors-servo r-

@fitzgen
Copy link
Member

fitzgen commented Nov 15, 2016

@bors-servo r+

@bors-servo
Copy link

📌 Commit 2895ae3 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 2895ae3 with merge 3b1ec9a...

bors-servo pushed a commit that referenced this pull request Nov 15, 2016
Avoid superfluous repeated builds on Travis

Another fix to greatly improve test suite turnaround times.
@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 2895ae3 into rust-lang:master Nov 16, 2016
@jdub jdub deleted the quick-fixes branch November 16, 2016 00:02
luser pushed a commit to luser/rust-bindgen that referenced this pull request Mar 27, 2017
Update dependencies: libc 0.2, syntex_syntax 0.29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants