Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document change of 'cargo' Runnable kind in lsp-extensions.md #6253

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Document change of 'cargo' Runnable kind in lsp-extensions.md #6253

merged 1 commit into from
Oct 16, 2020

Conversation

popzxc
Copy link
Contributor

@popzxc popzxc commented Oct 16, 2020

As was requested in #5954 (comment)

@lnicola
Copy link
Member

lnicola commented Oct 16, 2020

LGTM, but can you also add expectTest since it's there?

@popzxc popzxc force-pushed the document-runnables-lsp-extension-change branch from 7e9af09 to d718366 Compare October 16, 2020 17:59
@lnicola
Copy link
Member

lnicola commented Oct 16, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 16, 2020

Build succeeded:

@bors bors bot merged commit f0412da into rust-lang:master Oct 16, 2020
@popzxc popzxc deleted the document-runnables-lsp-extension-change branch October 16, 2020 18:08
@matklad matklad mentioned this pull request Oct 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popzxc @lnicola