Fix snippetTextEdits applying to other files #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think this is how it should be done. The whole thing is a hack basically :) r=me with styl fixed. We also need to rememebr to port this to https://github.com/rust-lang/vscode-rust |
bfa1bbf to
1b5a74e
Compare
vscode.window.visibleTextEditors only contains editors whose contents are being displayed at the moment, so the previous logic only worked if the other file for which a snippetTextEdit is being received was visible in a separate split.
TimoFreiberg
added a commit
to TimoFreiberg/vscode-rust
that referenced
this pull request
Jul 22, 2020
vscode.window.visibleTextEditors only contains editors whose contents are being displayed at the moment, so the previous logic only worked if the other file for which a snippetTextEdit is being received was visible in a separate split. Ported from rust-analyzer: rust-lang/rust-analyzer#5480
|
bors r+ |
|
Out of curiosity isn't a |
|
Yeah, I thought about this, but, for assists, I think we actually always want to unconditionally open the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4551
vscode.window.visibleTextEditorsonly contains editors whose contents are being displayed at the moment, so the previous logic only worked if the other file for which a snippetTextEdit is being received was visible in a separate split.I feel that this is a hacky approach, so feel free to reject it for something nicer :)