fix: Fix another issue with fixup reversing #18899
Merged
+85
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to *remove* the whole subtree, but we don't advance `i` by this, because it hasn't gotten there yet (and never will).
Veykril
reviewed
Jan 10, 2025
|
|
||
| // Reads ident type within string quotes, for issue #17479. | ||
| #[derive(Debug)] | ||
| struct Issue18898ProcMacroExpander; |
There was a problem hiding this comment.
Would be nice if we could manage to make these defs work in line (that is where the test is defined at least) as an improvement for the tsting infra
Veykril
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove the whole subtree, but we don't advance
iby this, because it hasn't gotten there yet (and never will).This was a stupid mistake on my part.
Fixes #18898.