-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a new and improved syntax tree view #18813
Conversation
3e592d7
to
25bcb6b
Compare
Also, would people be fine with this replacing the old textual syntax tree view? I could try to move some of the functionality to integrate with this feature if it's still desired. Maybe an action on each syntax element to copy the old format view to the clipboard? |
25bcb6b
to
2456c39
Compare
If it does allow debugging the syntax tree then there is no need for the old view |
632b3df
to
ba90f87
Compare
Here's a video of it in action syntaxtree.mp4 |
I think so, copying is still useful, e.g. when pasting to GitHub. |
Done! |
Couple things but otherwise this seems good to me! |
I guess we can't put a "Copy" icon next to 🔍, can we? |
7c1bdc7
to
c0f22c7
Compare
We can! Should be fixed. |
Thanks! |
I actually have no clue. VS Code registers both of these commands for us so I'm not sure why there's two, I'll take a look. |
It seems like since we're registering a custom view container, |
Ah, you're right, never mind. |
Lots of cool features!
I'm still pretty new to the VS Code side of things so there's probably a better way to do some of the stuff I did. If someone more familiar with this sort of thing wants to try to record a GIF or something of this in use, feel free. Otherwise I'll try to get one up in a bit,