Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Cleanup cfg and env handling in project-model #17108

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 19, 2024

Fixes #16122 (comment)

miri and debug_assertions are now enabled via the cargo.cfgs config by default, allowing them to be disabled by overwriting the config.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2024
@Veykril
Copy link
Member Author

Veykril commented Apr 19, 2024

Additionally, this also enables the use of the cargo.cfgs for other workspace kinds (detached files and rust-project.json), though arguably, the name doesn't really make sense anymore now. 8989dcf

cc @davidbarsky for thoughts on that part.

@davidbarsky
Copy link
Contributor

Additionally, this also enables the use of the cargo.cfgs for other workspace kinds (detached files and rust-project.json), though arguably, the name doesn't really make sense anymore now. 8989dcf

cc @davidbarsky for thoughts on that part.

Oh, I'm glad you made this change, but for naming, how does something like build.cfg feel?

(There's a few folks at work who wanted this; being able to point them to this setting would be immensely helpful!)

@Veykril
Copy link
Member Author

Veykril commented Apr 19, 2024

build is probably the right prefix here, but I'll not add that for now (we'll need to keep supporting cargo.cfgs for some time after anyways)
@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2024

📌 Commit cdb8c3a has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 19, 2024

⌛ Testing commit cdb8c3a with merge 50bdeaa...

@bors
Copy link
Contributor

bors commented Apr 19, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 50bdeaa to master...

@bors bors merged commit 50bdeaa into rust-lang:master Apr 19, 2024
11 checks passed
@bors bors mentioned this pull request Apr 19, 2024
@Veykril Veykril deleted the rustc-ws-hacks branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RA enable miri by default and cannot disable it
4 participants