fix: Some file watching related vfs fixes

[Veykril]

Fixes #15554, additionally it seems that client side file watching was broken on windows this entire time, this PR switches DidChangeWatchedFilesRegistrationOptions to use relative glob patterns which do work on windows in VSCode.

[lnicola]

Huh, it works for me 😛.

[Veykril]

Inbefore their file watcher works differently well between linux and windows

[Veykril]

Okay so VSCode just does not send a workspace/didChangeWatchedFiles notification when a file gets created even if it matches the glob pattern ... which I guess makes sense if you snapshot all existing files when we tell it what to watch? But at the same time, when will it ever send a created notification then ...?

[Veykril]

And no, this does not work for me whatsoever. Running cargo add yields no events from VSCode even 😕

[lnicola]

WDYM?

$ touch src/foo.rs # =>

[Trace - 9:57:23 PM] Sending notification 'workspace/didChangeWatchedFiles'.
Params: {
    "changes": [
        {
            "uri": "file:///Projects/hello/src/foo.rs",
            "type": 1
        },
        {
            "uri": "file:///Projects/hello/src/foo.rs",
            "type": 1
        }
    ]
}

[Veykril]

I don't get any such events from vscode :)

[lnicola]

Sounds like file watching is completely broken on Windows?

[Veykril]

Looks like it, tried it on my linux machine quickly and there touching does sent an event. Though I am surprised no one seems to have reported this so far

[Veykril]

Huh, switching over to using relative patterns makes it work! That's weird.

[Veykril]

@bors r+

[bors]

📌 Commit fe28e47 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit fe28e47 with merge 7ef7f44...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7ef7f44 to master...