Cancelable Initialization #15894
Cancelable Initialization #15894
Conversation
|
Seems fine to add for now, though long term we should consider what matklad wrote here #14582 (comment) |
…ykril Cancelable Initialization This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling. In the process of adding LSP to Nushell (see nushell/nushell#10941) this gap has been identified.
|
💔 Test failed - checks-actions |
|
Looks like this needs a rebase + Cargo.lock update |
f95d538 to
cdddd07
Compare
This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling.
cdddd07 to
81c2d35
Compare
|
@Veykril, I rebased this branch. Please, check it out again. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
And thank you very much for accepting this PR. |
|
Ye, we can cut a release for this. Given the changes a patch release should be fine (since we are below 1.0 with the lib still). Though I'm a bit busy right now |
|
@Veykril We were hoping this would be in the next release, but I guess it missed it (unless i'm reading something wrong). We have a nushell release on Dec 12th, is there any hope of a release that includes this change before then? If not, we'll need to rollback some changes. Thanks for your help! It was brought to my attention that it has been released here https://github.com/rust-lang/rust-analyzer/releases/tag/2023-11-27. yay! It just doesn't look like |
|
Oh sorry, I completely forgot to push the release for this, |
|
@Veykril, thank you very much for the release. I'll go ahead and update the Nushell dependencies. |
This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling.
In the process of adding LSP to Nushell (see nushell/nushell#10941) this gap has been identified.