Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Include toml files in the vfs #15880

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 12, 2023

Closes #15753

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2023
@lnicola
Copy link
Member Author

lnicola commented Nov 12, 2023

r? @Veykril do you think it's worth trying to limit this to clippy.toml and rust-analyzer.toml? I hope nobody has 200 MB TOMLs lying around...

@Veykril
Copy link
Member

Veykril commented Nov 12, 2023

I think it'd be fine to just include rust-analyzer.toml, Cargo.toml and clippy.toml (and . prefixed variants as well I guess? for clippy and r-a)

@Veykril
Copy link
Member

Veykril commented Nov 12, 2023

Assuming we can do that easily, I don't remember how this stuff works. Otherwise this seems fine to me as well

@lnicola
Copy link
Member Author

lnicola commented Nov 12, 2023

IIRC I looked into it and it didn't seem trivial. It even took me a lot of time to figure out how we load .rs files.

I think Cargo.toml and Cargo.lock are loaded with the workspace, while the code here filters by extension.

@Veykril
Copy link
Member

Veykril commented Nov 12, 2023

Does not surprise me, then let's keep it this way for now
@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2023

📌 Commit bad3d9e has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 12, 2023

⌛ Testing commit bad3d9e with merge 8bfe0aa...

@bors
Copy link
Contributor

bors commented Nov 12, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8bfe0aa to master...

@bors bors merged commit 8bfe0aa into rust-lang:master Nov 12, 2023
9 checks passed
@lnicola lnicola deleted the vfs-toml branch November 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flycheck 0: File with cargo diagnostic not found in VFS: file not found: clippy.toml
4 participants