Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use crate name for CARGO_CRATE_NAME #15574

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

alibektas
Copy link
Member

fixes #15572 . Until now we used the package name as a replacement of crate name. With this PR r-a first sets all the env variables it set before and on top of those it tries to set CARGO_CRATE_NAME to crates name, following envvar's naming convention.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2023
@alibektas alibektas changed the title minor : use real crate name for CARGO_CRATE_NAME minor : use crate name for CARGO_CRATE_NAME Sep 8, 2023
@Veykril
Copy link
Member

Veykril commented Sep 8, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 8, 2023

📌 Commit 506a477 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 8, 2023

⌛ Testing commit 506a477 with merge 5ddad87...

@bors
Copy link
Contributor

bors commented Sep 8, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 5ddad87 to master...

@bors bors merged commit 5ddad87 into rust-lang:master Sep 8, 2023
@lnicola lnicola changed the title minor : use crate name for CARGO_CRATE_NAME minor: use crate name for CARGO_CRATE_NAME Sep 9, 2023
@lnicola lnicola changed the title minor: use crate name for CARGO_CRATE_NAME fix: use crate name for CARGO_CRATE_NAME Sep 9, 2023
@alibektas alibektas deleted the 15572/false_crate_name_env branch April 16, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CARGO_CRATE_NAME is set incorrectly for integration tests and examples
4 participants