Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline all format arguments where possible #13835

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Dec 23, 2022

This makes code more readale and concise,
moving all format arguments like format!("{}", foo) into the more compact format!("{foo}") form.

The change was automatically created with clippy, so there are far less chance of an accidental typo.

cargo clippy --fix -- -A clippy::all -W clippy::uninlined_format_args

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 23, 2022
@bors
Copy link
Contributor

bors commented Dec 24, 2022

☔ The latest upstream changes (presumably #13830) made this pull request unmergeable. Please resolve the merge conflicts.

This makes code more readale and concise,
moving all format arguments like `format!("{}", foo)`
into the more compact `format!("{foo}")` form.

The change was automatically created with, so there are far less change
of an accidental typo.

```
cargo clippy --fix -- -A clippy::all -W clippy::uninlined_format_args
```
@nyurik nyurik force-pushed the inline_format_args branch from 7dd1340 to e16c76e Compare December 24, 2022 19:36
@lnicola
Copy link
Member

lnicola commented Dec 25, 2022

Thanks

@bors r+

@bors
Copy link
Contributor

bors commented Dec 25, 2022

📌 Commit e16c76e has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 25, 2022

⌛ Testing commit e16c76e with merge 2872e05...

@bors
Copy link
Contributor

bors commented Dec 25, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 2872e05 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants