-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix r-a spelling in some places #12919
Conversation
What do you mean by "other extensions don't do this"? |
They seem to be fairly consistently spelled in Upper Case, instead of snake-case |
One thing I’m noticing: This change requires touching 28 files, while the alternative requires touching a single file. That suggests to me that folks have intuitively thought “Rust Analyzer” is a more appropriate way to spell the name in user facing/documentation contexts. Also (maybe?) worth noting: the “logo” appears (at least to my eyes) to be spelled “rust.analyzer”, which isn’t consistent with either direction. |
That's because the alternative doesn't fix all the places mentioning rust-analyzer 😄 |
Yeah that's entirely fair. Did a quick search, you're 100% right, and it isn't close! |
Looks like people are generally in favor @bors r+ |
☀️ Test successful - checks-actions |
User-facing change: All commands are now rendered as "rust-analyzer: Command" rather than "Rust Analyzer: Command".
Alternative to #12910
Potentially controversial, since other extensions don't do this, so I won't self-approve.