Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix r-a spelling in some places #12919

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix: Fix r-a spelling in some places #12919

merged 1 commit into from
Aug 2, 2022

Conversation

jonas-schievink
Copy link
Contributor

User-facing change: All commands are now rendered as "rust-analyzer: Command" rather than "Rust Analyzer: Command".

Alternative to #12910

Potentially controversial, since other extensions don't do this, so I won't self-approve.

@flodiebold
Copy link
Member

What do you mean by "other extensions don't do this"?

@jonas-schievink
Copy link
Contributor Author

They seem to be fairly consistently spelled in Upper Case, instead of snake-case

@DorianListens
Copy link
Contributor

One thing I’m noticing: This change requires touching 28 files, while the alternative requires touching a single file. That suggests to me that folks have intuitively thought “Rust Analyzer” is a more appropriate way to spell the name in user facing/documentation contexts.

Also (maybe?) worth noting: the “logo” appears (at least to my eyes) to be spelled “rust.analyzer”, which isn’t consistent with either direction.

@flodiebold
Copy link
Member

One thing I’m noticing: This change requires touching 28 files, while the alternative requires touching a single file. That suggests to me that folks have intuitively thought “Rust Analyzer” is a more appropriate way to spell the name in user facing/documentation contexts.

That's because the alternative doesn't fix all the places mentioning rust-analyzer 😄

@DorianListens
Copy link
Contributor

Yeah that's entirely fair. Did a quick search, you're 100% right, and it isn't close!

@jonas-schievink
Copy link
Contributor Author

Looks like people are generally in favor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 2, 2022

📌 Commit bd7dfac has been approved by jonas-schievink

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 2, 2022

⌛ Testing commit bd7dfac with merge c6c0ac2...

@bors
Copy link
Contributor

bors commented Aug 2, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing c6c0ac2 to master...

@bors bors merged commit c6c0ac2 into rust-lang:master Aug 2, 2022
@jonas-schievink jonas-schievink deleted the speling branch August 2, 2022 13:31
@Veykril Veykril mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants