-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add str_ref_to_string fix #12696
Add str_ref_to_string fix #12696
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
be023ab
to
b9ba9fa
Compare
ed1153c
to
638abba
Compare
@Veykril |
I'm a bit busy atm, will take a look when I find the time (unless someone beats me to it) |
We probably want this to be a bit more generally applicable if possible (and certainly not just text based by checking the types names) but in this instance this seems fine for now I think. We can figure out the better way afterwards since this is self-contained. Thanks |
☀️ Test successful - checks-actions |
add-to-string.mp4 |
I feel like |
close #11383
When type mismatch is
&str
->String
try to fix it.