-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve extension description and README #12242
Conversation
6aa368d
to
85fe939
Compare
editors/code/package.json
Outdated
@@ -1,15 +1,15 @@ | |||
{ | |||
"name": "rust-analyzer", | |||
"displayName": "rust-analyzer", | |||
"description": "A language server for the rust programming language", | |||
"description": "The future of Rust support in VSCode.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the present hopefully 😅,
(I'm worried this sounds too much like "experimental")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't know, maybe someone has a nicer description 😄 I guess we could also go for something more 'boring', but I felt this helps a bit more to differentiate this extension from rust-lang.rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The New and Improved Rust extension!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just say "Rust language support for Visual Studio Code". And the rust-lang.rust one should say "use the other one!"
editors/code/package.json
Outdated
@@ -1,15 +1,15 @@ | |||
{ | |||
"name": "rust-analyzer", | |||
"displayName": "rust-analyzer", | |||
"description": "A language server for the rust programming language", | |||
"description": "The future of Rust support in VSCode.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just say "Rust language support for Visual Studio Code". And the rust-lang.rust one should say "use the other one!"
@@ -1,15 +1,15 @@ | |||
{ | |||
"name": "rust-analyzer", | |||
"displayName": "rust-analyzer", | |||
"description": "A language server for the rust programming language", | |||
"description": "The future of Rust support in VSCode.", | |||
"preview": true, | |||
"private": true, | |||
"icon": "icon.png", | |||
"version": "0.4.0-dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to fix the version generating code?
@bors r+ |
📌 Commit 3dcf9e0 has been approved by |
☀️ Test successful - checks-actions |
No description provided.