Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extension description and README #12242

Merged
merged 2 commits into from
May 15, 2022

Conversation

flodiebold
Copy link
Member

No description provided.

@flodiebold flodiebold force-pushed the extension-description branch from 6aa368d to 85fe939 Compare May 13, 2022 16:15
@@ -1,15 +1,15 @@
{
"name": "rust-analyzer",
"displayName": "rust-analyzer",
"description": "A language server for the rust programming language",
"description": "The future of Rust support in VSCode.",
Copy link
Member

@lnicola lnicola May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the present hopefully 😅,

(I'm worried this sounds too much like "experimental")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know, maybe someone has a nicer description 😄 I guess we could also go for something more 'boring', but I felt this helps a bit more to differentiate this extension from rust-lang.rust

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The New and Improved Rust extension!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just say "Rust language support for Visual Studio Code". And the rust-lang.rust one should say "use the other one!"

@@ -1,15 +1,15 @@
{
"name": "rust-analyzer",
"displayName": "rust-analyzer",
"description": "A language server for the rust programming language",
"description": "The future of Rust support in VSCode.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just say "Rust language support for Visual Studio Code". And the rust-lang.rust one should say "use the other one!"

@@ -1,15 +1,15 @@
{
"name": "rust-analyzer",
"displayName": "rust-analyzer",
"description": "A language server for the rust programming language",
"description": "The future of Rust support in VSCode.",
"preview": true,
"private": true,
"icon": "icon.png",
"version": "0.4.0-dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to fix the version generating code?

@flodiebold
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented May 15, 2022

📌 Commit 3dcf9e0 has been approved by flodiebold

@bors
Copy link
Contributor

bors commented May 15, 2022

⌛ Testing commit 3dcf9e0 with merge ac4ce42...

@bors
Copy link
Contributor

bors commented May 15, 2022

☀️ Test successful - checks-actions
Approved by: flodiebold
Pushing ac4ce42 to master...

@bors bors merged commit ac4ce42 into rust-lang:master May 15, 2022
@flodiebold flodiebold deleted the extension-description branch May 17, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants