Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.207 not working in VSCode 1.46.0 #4938

Closed
krooq opened this issue Jun 18, 2020 · 7 comments
Closed

v0.2.207 not working in VSCode 1.46.0 #4938

krooq opened this issue Jun 18, 2020 · 7 comments

Comments

@krooq
Copy link

krooq commented Jun 18, 2020

I've installed the latest rust-analyzer release (v0.2.207) in VSCode (1.46.0) and it doesn't seem to work at all.
VSCode says its installed and enabled via the extensions tab but no commands are appear when I search with ctrl+shift+P, no analysis is performed, no option for rust analyzer in the output tab, no prompt to install language server, it's just as if it isn't there.

I tried

  • switching workspaces/projects
  • restarting VSCode
  • reinstalling rust-analyzer
  • uninstalling all other extensions

I reinstalled the previous rust analyzer version v0.2.199 and it works fine.

My VSCode installation and OS version

Version: 1.46.0
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-10T09:03:20.462Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
@Veetaha
Copy link
Contributor

Veetaha commented Jun 18, 2020

Could you please share us the log output of the extension? It is under Help -> Toggle Developer Tools -> Console?

@notheotherben
Copy link

notheotherben commented Jun 19, 2020

I'm seeing the following error in the VSCode Console under similar conditions.

Activating extension 'matklad.rust-analyzer' failed: EBUSY: resource busy or locked, open '%AppData%\Code\User\globalStorage\matklad.rust-analyzer\rust-analyzer-windows.exe'.

Note that %AppData% is expanded in the log entry, but I've redacted it here.

For what it's worth, it seems this was caused by having multiple VSCode instances running simultaneously and shutting down all other instances resolved my problem. Might be worth handling this EBUSY and warning users about it?

@bjorn3
Copy link
Member

bjorn3 commented Jun 19, 2020

@spartan563 Try closing all vscode windows and ensuring that rust-analyzer-windows.exe is no longer running. Then you can open vscode again and the download should succeed.

@Veetaha
Copy link
Contributor

Veetaha commented Jun 19, 2020

Yeah, probably we should fix this issue or at least throw a proper error indication (this should have been done quite much earlier than right now I guess). I'll try to tackle this...

@krooq
Copy link
Author

krooq commented Jun 20, 2020

@Veetaha, this is the error I'm getting in the console

Activating extension 'matklad.rust-analyzer' failed: Cannot find module '<my-user-dir>\.vscode\extensions\matklad.rust-analyzer-0.2.207\out\src\main'
Require stack:
- <my-vscode-install>\resources\app\out\vs\loader.js
- <my-vscode-install>\resources\app\out\bootstrap-amd.js
- <my-vscode-install>\resources\app\out\bootstrap-fork.js.

VSCode 1.46.1 is out now, I'll try that version and report back.

EDIT: 1.46.1 produces the same error

It does appear that there is no \out\src\main directory in the extension install folder

@Veetaha
Copy link
Contributor

Veetaha commented Jun 20, 2020

@krooq that's very weird, try the following strictly in order:

  • Click Uninstall rust-analyzer extension in vscode
  • Close vscode
  • Remove <my-user-dir>\.vscode\extensions\matklad.rust-analyzer-0.2.207
  • Install rust-analyzer once again

@krooq
Copy link
Author

krooq commented Jun 20, 2020

Ok that worked! cool!
Must have been a messed up install of the RLS which windows/vscode cached somewhere.
Thanks a bunch!

I'll close this ticket as I think this is just an odd case and probably a dodgy Australian internet connection thing.

@krooq krooq closed this as completed Jun 20, 2020
bors bot added a commit that referenced this issue Jun 21, 2020
4963: Download artifacts into tmp dir r=matklad a=Veetaha

This should prevent partially downloaded files in cases when the user closes vsode before the download is complete.
There is also a new more descriptive error message when the user has multiple vscode windows open and tries to download the server.
Related: #4938 (comment)

Co-authored-by: Veetaha <veetaha2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants