Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename editor.action.triggerParameterHints and editor.action.rename command capabilities #17644

Closed
Veykril opened this issue Jul 20, 2024 · 1 comment · Fixed by #17647
Closed

Rename editor.action.triggerParameterHints and editor.action.rename command capabilities #17644

Veykril opened this issue Jul 20, 2024 · 1 comment · Fixed by #17647
Labels
A-config configuration A-lsp LSP conformance issues and missing features

Comments

@Veykril
Copy link
Member

Veykril commented Jul 20, 2024 

          Same goes for the `"editor.action.triggerParameterHints",` capability. Thanks for calling that out I think we should move those over to `rust-analyzer.*` or similar. The names are based on the equivalent vscode commands but we should clearly not use the exact same names for those.

Originally posted by @Veykril in #17587 (comment)
@Veykril Veykril added A-lsp LSP conformance issues and missing features A-config configuration labels Jul 20, 2024
@joshka joshka mentioned this issue Jul 20, 2024
Merged
@joshka
Copy link
Contributor

joshka commented Jul 20, 2024

#17647

bors added a commit that referenced this issue Jul 22, 2024
@bors
Auto merge of #17647 - joshka:jm/rename-commands, r=Veykril
c29bac1 
Rename rust-analyzer commands

The commands `editor.action.triggerParameterHints` and
`editor.action.rename` are now renamed to
`rust-analyzer.triggerParameterHints` and `rust-analyzer.rename`

This change helps make it clear that these commands are specific to
rust-analyzer and not part of the default set of commands provided by
VSCode.

Fixes: #17644

Note: This seems like it will be a breaking change for any RA client that previously reacted to `editor.action.triggerParameterHints` - naive search: https://github.com/search?q=editor.action.triggerParameterHints+AND+%28NOT+is%3Afork%29+rust-analyzer&type=code
@bors bors closed this as completed in 5b1a5a2 Jul 22, 2024
Veykril pushed a commit to Veykril/rust-analyzer that referenced this issue Jul 25, 2024
@joshka @Veykril
Rename rust-analyzer commands
6dd851a 
The commands `editor.action.triggerParameterHints` and
`editor.action.rename` are now renamed to
`rust-analyzer.triggerParameterHints` and `rust-analyzer.rename`

This change helps make it clear that these commands are specific to
rust-analyzer and not part of the default set of commands provided by
VSCode.

Fixes: rust-lang#17644
lnicola pushed a commit to lnicola/rust that referenced this issue Jul 28, 2024
@joshka
Rename rust-analyzer commands
539df3f 
The commands `editor.action.triggerParameterHints` and
`editor.action.rename` are now renamed to
`rust-analyzer.triggerParameterHints` and `rust-analyzer.rename`

This change helps make it clear that these commands are specific to
rust-analyzer and not part of the default set of commands provided by
VSCode.

Fixes: rust-lang/rust-analyzer#17644
lnicola pushed a commit to lnicola/rust that referenced this issue Jul 28, 2024
@bors
Auto merge of rust-lang#17647 - joshka:jm/rename-commands, r=Veykril
0f45488 
Rename rust-analyzer commands

The commands `editor.action.triggerParameterHints` and
`editor.action.rename` are now renamed to
`rust-analyzer.triggerParameterHints` and `rust-analyzer.rename`

This change helps make it clear that these commands are specific to
rust-analyzer and not part of the default set of commands provided by
VSCode.

Fixes: rust-lang/rust-analyzer#17644

Note: This seems like it will be a breaking change for any RA client that previously reacted to `editor.action.triggerParameterHints` - naive search: https://github.com/search?q=editor.action.triggerParameterHints+AND+%28NOT+is%3Afork%29+rust-analyzer&type=code
nemethf added a commit to nemethf/eglot-x that referenced this issue Jul 30, 2024
@nemethf
Implement client command "rust-analyzer.rename"
29d513e 
The motivation is to trigger a rename after extract variable assist is
applied: rust-lang/rust-analyzer#17587

The implementation might need to be updated later:
rust-lang/rust-analyzer#17644

* eglot-x.el (eglot-x-client-commands): New defcustom.
(eglot-client-capabilities): Set experimental/commands based on the
defcustom.
(eglot-x--apply-text-edits): Sync with upstream version of
eglot--apply-text-edits, and remove heuristic to detect a snippet,
which is no longer needed.
(eglot-x-execute-command): New defun.  Handle the client command
"rust-analyzer.rename" locally.
(elgot-execute): New cl-defmethod.  Extend the default implementation
by calling eglot-x-execute-command for commands.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 1, 2024
@joshka
Rename rust-analyzer commands
f3a1d4c 
The commands `editor.action.triggerParameterHints` and
`editor.action.rename` are now renamed to
`rust-analyzer.triggerParameterHints` and `rust-analyzer.rename`

This change helps make it clear that these commands are specific to
rust-analyzer and not part of the default set of commands provided by
VSCode.

Fixes: rust-lang/rust-analyzer#17644
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 1, 2024
@bors
Auto merge of rust-lang#17647 - joshka:jm/rename-commands, r=Veykril
91b8226 
Rename rust-analyzer commands

The commands `editor.action.triggerParameterHints` and
`editor.action.rename` are now renamed to
`rust-analyzer.triggerParameterHints` and `rust-analyzer.rename`

This change helps make it clear that these commands are specific to
rust-analyzer and not part of the default set of commands provided by
VSCode.

Fixes: rust-lang/rust-analyzer#17644

Note: This seems like it will be a breaking change for any RA client that previously reacted to `editor.action.triggerParameterHints` - naive search: https://github.com/search?q=editor.action.triggerParameterHints+AND+%28NOT+is%3Afork%29+rust-analyzer&type=code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-config configuration A-lsp LSP conformance issues and missing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal: Rename rust-analyzer commands joshka/rust-analyzer
2 participants
@joshka @Veykril