-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lens.forceCustomCommands
config
#17643
Comments
For context, the original reason for this setting being set to true is documented in Veykril@be84f85#diff-779cb31c0defa0631d570725eb4ca124c0860d6ec07bb5b9deddc2dd34966315 in July 2021:
|
@rustbot claim |
…nfig, r=lnicola Remove lens.forceCustomCommands config Closes #17643 A very simple PR that removes the lens.forceCustomCommands config feature without side effects.
…mmands-config, r=lnicola Remove lens.forceCustomCommands config Closes rust-lang/rust-analyzer#17643 A very simple PR that removes the lens.forceCustomCommands config feature without side effects.
…mmands-config, r=lnicola Remove lens.forceCustomCommands config Closes rust-lang/rust-analyzer#17643 A very simple PR that removes the lens.forceCustomCommands config feature without side effects.
That depends on the client, we are violating the LSP (or in this case the lsp extension I suppose), we shouldn't be doing that.
The problem is this config being enabled by default for some reason https://github.com/veykril/rust-analyzer/blob/09ef75c717e9ffb4cbc71ce1cfec7694244742c2/crates/rust-analyzer/src/config.rs#L564 which then force enables all of the commands here https://github.com/veykril/rust-analyzer/blob/09ef75c717e9ffb4cbc71ce1cfec7694244742c2/crates/rust-analyzer/src/config.rs#L1896-L1911
We should just get rid of
lens_forceCustomCommands
, I see no value in it for debugging.Originally posted by @Veykril in #17587 (comment)
The text was updated successfully, but these errors were encountered: