Skip to content

Commit

Permalink
Auto merge of #136352 - lqd:ensure-stacks, r=compiler-errors
Browse files Browse the repository at this point in the history
Add a couple of missing `ensure_sufficient_stacks`

r? `@saethlin` I hope you didn't spend time on this already.

(I couldn't sleep, opened `check_tail_calls`, there was a single call where it could happen, might as well fix it)

This PR adds a couple of missing `ensure_sufficient_stack`s:
- one in `check_tail_calls` that prevented the #135709 backport on some targets.
- after that was fixed, the test still didn't pass starting at 4MB, so I also added one in `check_unsafety` and that made it pass.

I didn't add an `rmake` test purposefully limiting the min stack size on `issue-74564-if-expr-stack-overflow.rs`, but we could if we wanted to.

On `apple-aarch64-darwin`, this is enough to make `RUST_MIN_STACK=$((1024*1024*3)) ./x test tests/ui --test-args tests/ui/issues/issue-74564-if-expr-stack-overflow.rs` pass for me locally, and it does stack overflow otherwise.
  • Loading branch information
bors committed Feb 3, 2025
2 parents 9aa5dfb + c43ffa6 commit 514bb54
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 514bb54

Please sign in to comment.