This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Fallback to racer definition #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2018
Merged
|
Stuck? |
Xanewok
approved these changes
Dec 6, 2018
|
This looks good now, thanks @alexheretic! It's not stuck - I'd just like to hear @nrc's thoughts on enabling the fallback by default, since I remember we did this for reasons (potentially misleading or costly at that time? Can't remember 😢 ) |
8122237 to
3e36a0a
Compare
Closed
* Runs racer find_definition if analysis goto has failed and `racer_completion` config is enabled. This brings the functionality in line with hover. * Removed `goto_def_racer_fallback`. * Ignore clippy large enum lint in `BuildPlan`
3e36a0a to
2d16f79
Compare
|
Thanks! And sorry for the delay! |
dvic
added a commit
to dvic/rls-vscode
that referenced
this pull request
Feb 23, 2019
What I understand, it has been replaced by the existing `racer_completion` config attribute: rust-lang/rls#1152 Fixes rust-lang#510
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having a look at handling lsp in out-of-project rust files, like dependencies, for ide-rust which got me more interested in this. From the discussions in #1139 & #1106 I think we got fairly close to consensus.
racer_completionconfig is enabled. This brings the functionality in line with hover (now in both cases racer calls are lazy).goto_def_racer_fallbackconfig.BuildPlan.I think reusing
racer_completionconfig is desirable, as the only known reason to disable this is when racer has critical performance issues with a project. In these cases we'd also not want any racer-fallbacks to run. In other cases where analysis works these fallbacks have no cost, so again I don't see an advantage in having a separate config.Resolves #1106
Resolves #1139