Remove crate_visibility_modifier

[alexheretic]

As I understand it; the ship has sailed on crate visibility. We should remove these preferring pub(crate) usage instead.

Implementation

Get rid of this

rls/src/lib.rs

Line 9 in c9d25b6

#![feature(crate_visibility_modifier)] // needed for edition 2018

Fix all the errors

rls/src/build/cargo_plan.rs

Line 74 in c9d25b6

crate fn with_manifest(manifest_path: &Path) -> CargoPlan {

[alexheretic]

@Xanewok if you agree with this, it would be a good starting issue.

[Xanewok]

Yeah, sounds good!

[h-michael]

@alexcrichton
I try this.
There's something I'd like to ask you.
Why should we remove this?

[alexheretic]

@h-michael when this was put in it was pre edition 2018 and it looked like crate fn foo style visibility would be released with the edition. This did not turn out to be the case.

Generally we should prefer to use idiomatic or future-idiomatic rust, this syntax is no longer either.

[coffeenotfound]

What?? Why?

[griffi-gh]

What?? Why?

pub(crate) is better and does the same thing without introducing an extra keyword