Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unicodeset link #2842

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Update unicodeset link #2842

merged 1 commit into from
Jan 1, 2020

Conversation

Manishearth
Copy link
Member

The syntax changed and the links broke.

r? @Centril

@Centril Centril merged commit 6ad6edf into rust-lang:master Jan 1, 2020
@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Jan 1, 2020
@Manishearth
Copy link
Member Author

Also wondering if I should update the RFC to use the term uncommon_codepoints (the RFC says less_used_codepoints but it left that up as an unresolved question and the tracking issue has settled on uncommon_codepoints), but my understanding is that we typically don't update RFCs to reflect decisions made later? (@nikomatsakis ?)

@Manishearth Manishearth deleted the nonascii-fixes branch January 1, 2020 04:25
@Centril
Copy link
Contributor

Centril commented Jan 1, 2020

but my understanding is that we typically don't update RFCs to reflect decisions made later? (@nikomatsakis ?)

We don't require it, but I personally wouldn't mind accepting & reviewing such fixes and clarifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril approved these changes

Assignees
No one assigned
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @Centril