Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PR to pull request #1902

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

kalisjoshua
Copy link
Contributor

There was an inconsistent use of "PR" and "pull request" throughout the
document. I believe that I read an article from GitHub that they suggested
the use of "pull request" instead of "PR" for the purposes of clarity.

There was an inconsistent use of "PR" and "pull request" throughout the
document. I believe that I read an article from GitHub that they suggested
the use of "pull request" instead of "PR" for the purposes of clarity.
@alexcrichton alexcrichton merged commit b23226f into rust-lang:master Feb 16, 2017
@alexcrichton
Copy link
Member

Thanks!

@kalisjoshua kalisjoshua deleted the pr-to-pull-request branch February 16, 2017 16:52
@kalisjoshua
Copy link
Contributor Author

I have some additional - slightly more drastic - changes to submit too. Some are simply formatting changes to the markdown (mostly all consistency related) and other wording changes that I didn't want to include in one big PR. Ill submit that soon.

@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants