-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of pipe operator in patterns. #1882
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
- Feature Name: pipe_in_sub_expressions. | ||
- Start Date: 2017-02-03 | ||
- RFC PR: (leave this empty) | ||
- Rust Issue: (leave this empty) | ||
|
||
## Summary | ||
this RFC proposes allowing the `|` operator to be used within patterns in match | ||
statements, to allow for pattern matching with less boilerplate. | ||
|
||
## Detailed Design | ||
The current pattern matching in `match` statements is very powerful, however | ||
there is a lot of boilerplate code needed to fully take advantage of it. | ||
Consider a situation where you are building a state machine that is iterating | ||
through `chars_indices`, and when you see `' '`, `'\n'`, `'\r'` or `'\f'`, you | ||
want to change the state. Currently your match statement would look something | ||
like the following example. There is no great way of reducing that boilerplate, | ||
if anything that boilerplate only grows worse as you have more cases, and bigger | ||
tuples. Conservatively this feature would be simple syntactic sugar that just | ||
expands to the old syntax. | ||
|
||
```rust | ||
match iter.next() { | ||
Some(_, ' ') | Some(_, '\n') | Some(_, '\r') | Some(_, '\u{21A1}') => { | ||
// Change state | ||
} | ||
Some(index, ch) => { | ||
// Look at char | ||
} | ||
None => return Err(Eof), | ||
} | ||
``` | ||
|
||
The solution to this would be to allow for `|` to be used within tuples. This | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be restricted to tuple patterns. |
||
will significantly reduce how much boilerplate is required to have conditional | ||
matches with tuples. | ||
|
||
```rust | ||
match iter.next() { | ||
Some(_, ' ' | '\n' | '\r' | '\u{21A1}') => { | ||
// Change state | ||
} | ||
Some(index, ch) => { | ||
// Look at char | ||
} | ||
None => return Err(Eof), | ||
} | ||
``` | ||
In terms of Rust's grammar `pats_or` would probably be changed to the following. | ||
Which should allow for `Some(1 | 2 | 3, ' ' | '\n' | '\r')`. | ||
|
||
```yacc | ||
pats_or | ||
: pat { $$ = mk_node("Pats", 1, $1); } | ||
| pat '|' pat { $$ = ext_node($1, 1, $3); } | ||
; | ||
``` | ||
|
||
## How We Teach This | ||
I think all that would be required is additional examples in sections on | ||
pattern matching. The syntax is very intuitive. | ||
|
||
## Drawbacks | ||
None that I can think of. | ||
|
||
## Alternatives | ||
Keep syntax as is. | ||
|
||
## Unresolved Questions | ||
None at the moment. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should apply to all patterns, not just patterns in
match
statements.