Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String should implement BorrowMut<str> #1282

Closed
stouset opened this issue Sep 15, 2015 · 0 comments · Fixed by rust-lang/rust#60404
Closed

String should implement BorrowMut<str> #1282

stouset opened this issue Sep 15, 2015 · 0 comments · Fixed by rust-lang/rust#60404
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.

Comments

@stouset
Copy link

stouset commented Sep 15, 2015

String implements Borrow<str>. Now that #1157 is implemented, String should probably implement BorrowMut<str> as well.
@nrc nrc added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Aug 22, 2016
@lo48576 lo48576 mentioned this issue Apr 30, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
4a2604d 
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.
Centril added a commit to Centril/rust that referenced this issue May 1, 2019
@Centril
Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
a31ec19 
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.
Centril added a commit to Centril/rust that referenced this issue May 1, 2019
@Centril
Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
682553d 
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.
Centril added a commit to Centril/rust that referenced this issue May 1, 2019
@Centril
Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
c8c195f 
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement BorrowMut<str> for String lo48576/rust
2 participants
@stouset @nrc