Document desugarings that happen when creating hir #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alercah
reviewed
Sep 9, 2018
src/expressions/loop-expr.md
Outdated
|
|
||
| ```rust | ||
| { | ||
| let result = match IntoIterator::into_iter(iter_expr) { |
There was a problem hiding this comment.
IIRC there should be some note here about how into_iter is looked up? It's not a lang item.
alercah
reviewed
Sep 9, 2018
src/expressions/loop-expr.md
Outdated
| { | ||
| let result = match IntoIterator::into_iter(iter_expr) { | ||
| mut iter => 'label: loop { | ||
| let next; |
There was a problem hiding this comment.
Could we simplify this by let PAT = match ...?
There was a problem hiding this comment.
I can't work out how let mut next = ... would be different, but let PAT = match would have a different drop order when PAT is something like (x, _).
There was a problem hiding this comment.
This is why it can't be simplified.
5eab25f to
1d19008
Compare
|
Comments addressed |
1d19008 to
d659d0e
Compare
alercah
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46
Closes #47