Make DatafrogOpt produce errors #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Produce "errors" tuples primarily - Produce "borrow_live_at" tuples only in verbose mode - Adds a test to check that issue 47680 does not produce errors - Made the tests run in Verbose mode so that the `borrow_live_at` tuples are available. And a couple cleanups: - Separate static data inputs - Rename a relation named like an index
nikomatsakis
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
borrow_live_attuplesare available.
And a couple cleanups:
As this adds a join with a big relation in the clap benchmark, it is expected to have a slowdown, which we can most likely eliminate when adding leapjoins.
Manually tested that this produces the same
borrow_live_atand verbose data as before. Unfortunately, there are no inputs that would fail the location-sensitive analysis in the repo such as this important test case. (And I don't have the custom rustc adding theseinvalidatestuples)