Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links in other-reprs.md #115

Closed
wants to merge 1 commit into from
Closed

Fix links in other-reprs.md #115

wants to merge 1 commit into from

Conversation

cmyr
Copy link
Contributor

@cmyr cmyr commented Dec 26, 2018

The rust-bindgen link was out of date, and the cbindgen link was misspelled in the text.

@cmyr
Fix links in other-reprs.md
1b2b685 
The rust-bindgen link was out of date, and the cbindgen link was misspelled in the text.
Gankra
Gankra approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Gankra
Copy link
Contributor

Gankra commented Feb 26, 2019

oops, another pr fixed the bindgen part already (also can you not remove the extra []'s? while not strictly necessary they make the document less syntactically ambiguous in certain situations).

@Gankra
Copy link
Contributor

Gankra commented Feb 26, 2019

Ah perfect #112 is exactly that.

Thanks anyway!

@Gankra Gankra closed this Feb 26, 2019
@cmyr cmyr deleted the patch-2 branch February 28, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gankra Gankra Gankra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @Gankra